Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Polish notification button #9239

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Polish notification button #9239

merged 3 commits into from
Jun 9, 2017

Commits on Jun 6, 2017

  1. Increase notification buttons height with px 

    from a viewpoint of accessibility

Fixes #9237

Auditors:

Test Plan:
1. Open about:preferences#general
2. Change lang setting
3. Click 'No' with a mouse using an arm opposite to a dominant arm
4. Check if you could click the button more easily than the current one
    Suguru Hirahara committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    664af88 View commit details
    Browse the repository at this point in the history

  2. Polish buttons on about:styles 

    Fixes #9238
Closes #9280

- Reorganize secondaryColor and primaryColor buttons
- Add overflow-x to pre
- Add secondaryColor to notificationItem

Auditors:

Test Plan:
1. Open about:styles#buttons
2. Make sure the notificationItem button is rendered as a white button
3. Make sure the code sample boxes are scrollable
    Suguru Hirahara committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    1cc467e View commit details
    Browse the repository at this point in the history

  3. Add groupedItem to notification buttons

    Suguru Hirahara committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    bdb27c7 View commit details
    Browse the repository at this point in the history