Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes non-primitive props from Frame #9762

Closed
wants to merge 1 commit into from

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 28, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9760

Auditors: @bridiver @bsclifton

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 28, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 28, 2017
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jun 29, 2017

This PR will probably not be needed, because of this PR #9475

@bridiver
Copy link
Collaborator

bridiver commented Jun 29, 2017

yea, closing in favor of #9475

@bridiver bridiver closed this Jun 29, 2017
@luixxiul luixxiul removed this from the 0.19.x (Nightly Channel) milestone Jun 30, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jun 30, 2017

When closing please remove the milestone, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants