Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only primitives in Frame #9760

Closed
NejcZdovc opened this issue Jun 28, 2017 · 3 comments
Closed

Only primitives in Frame #9760

NejcZdovc opened this issue Jun 28, 2017 · 3 comments
Assignees
@NejcZdovc
Labels
perf QA/no-qa-needed refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:
Remove allSiteSettings from mergeProps.
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 28, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 28, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 28, 2017
@NejcZdovc
Removes non-primitive props from Frame
a752c33 
Resolves brave#9760

Auditors: @bridiver @bsclifton

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 28, 2017
Closed
8 tasks
@NejcZdovc
Copy link
Contributor Author

Mostly done in #9475, some more work in here #9899

@luixxiul
Copy link
Contributor

no-qa-needed?

@NejcZdovc
Copy link
Contributor Author

no QA needed, because this issue was fixed with other PR's that has their own tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/no-qa-needed refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
2 participants
@luixxiul @NejcZdovc