Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes some possible null scenarios; Some linting and code clean up #9899

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Fixes some possible null scenarios; Some linting and code clean up #9899

merged 1 commit into from
Jul 12, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 7, 2017 •
edited
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9898

Auditors: @bsclifton @bridiver

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Developer Channel) milestone Jul 7, 2017
@NejcZdovc NejcZdovc self-assigned this Jul 7, 2017
@NejcZdovc NejcZdovc requested review from bridiver and bsclifton July 7, 2017 07:56
@NejcZdovc NejcZdovc mentioned this pull request Jul 10, 2017
Closed
@NejcZdovc NejcZdovc merged commit bebfb2e into brave:master Jul 12, 2017
bsclifton
bsclifton reviewed Jul 12, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc mentioned this pull request Jul 18, 2017
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request Jul 20, 2017
@NejcZdovc
Fixes some regression that was introduced with brave#9899
d36ff7d 
Auditors: @bsclifton

Test Plan:
- check if title mode is working
NejcZdovc added a commit that referenced this pull request Jul 20, 2017
@NejcZdovc
Merge pull request #10071 from NejcZdovc/hotfix/follow-#9899
7de868a 
Fixes some regression that was introduced with #9899
NejcZdovc added a commit that referenced this pull request Jul 20, 2017
@NejcZdovc
Fixes some regression that was introduced with #9899
b769739 
Auditors: @bsclifton

Test Plan:
- check if title mode is working
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton left review comments

@bridiver bridiver bridiver approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
QA/no-qa-needed refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @bridiver @bsclifton