This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Make desktop name configurable from browser-laptop #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
desktopNameArg
branch
from
82d2304 to
bbcbd1c
Compare
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 14, 2017
requires brave/muon#309 Auditors: @bsclifton, @bbondy Test Plan:
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 14, 2017
also fix #1336 requires brave/muon#309 Auditors: @bsclifton, @bbondy Test Plan:
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 14, 2017
also fix #1336 requires brave/muon#309 Auditors: @bsclifton, @bbondy Test Plan:
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 14, 2017
also fix #1336 requires brave/muon#309 Auditors: @bsclifton, @bbondy Test Plan:
posix4e
reviewed
Sep 14, 2017
| @@ -118,6 +123,12 @@ bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, | |||
| // |protocol|. | |||
| bool Browser::IsDefaultProtocolClient(const std::string& protocol, | |||
| mate::Arguments* args) { | |||
| std::string desktop_name; | |||
| if (!args->GetNext(&desktop_name)) { | |||
There was a problem hiding this comment.
Should we check to see if it's empty?
There was a problem hiding this comment.
The empty desktop name does no harm. For IsDefaultProtocolClient, the final result will be false and SetAsDefaultProtocolClient would be no effect.
posix4e
approved these changes
Sep 14, 2017
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 14, 2017
also fix #1336 requires brave/muon#309 Auditors: @bsclifton, @bbondy Test Plan:
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 15, 2017
…wser` requires brave/muon#309 fix #1336 Auditors: @bsclifton, @bbondy Test Plan: 1. Set default browser to non Brave browser 2. Open Brave from fresh profile 3. You should see Brave ask to set as default 4. Click Yes, in about:preferences#general, you should see Brave is your default browser 5. Check system setting, default browser should be Brave
Merged
8 tasks
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 16, 2017
…wser` requires brave/muon#309 fix #1336 Auditors: @bsclifton, @bbondy Test Plan: 1. Set default browser to non Brave browser 2. Open Brave from fresh profile 3. You should see Brave ask to set as default 4. Click Yes, in about:preferences#general, you should see Brave is your default browser 5. Check system setting, default browser should be Brave
bsclifton
reviewed
Sep 19, 2017
|
please mark with branch labels/milestone |
bsclifton
approved these changes
Sep 21, 2017
|
Should be merged for browser-laptop 0.20.x BUT it can happen earlier in Muon because browser-laptop has backwards compatible change (brave/browser-laptop#10974) |
bsclifton
added a commit
that referenced
this pull request
Sep 22, 2017
Make desktop name configurable from browser-laptop
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Sep 25, 2017
also fix #1336 requires brave/muon#309 Auditors: @bsclifton, @bbondy Test Plan:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bsclifton, @bbondy