This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Check args before using it #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/browser-laptop#11330 Auditors: @brividr, @bsclifton, @bbondy
bridiver
reviewed
Oct 10, 2017
| @@ -89,7 +89,7 @@ bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, | |||
| bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, | |||
| mate::Arguments* args) { | |||
| std::string desktop_name; | |||
| if (!args->GetNext(&desktop_name)) { | |||
| if (args && !args->GetNext(&desktop_name)) { | |||
There was a problem hiding this comment.
args should always exist, where are you seeing it as null?
There was a problem hiding this comment.
WebContents::OnRegisterProtocol in atom/browser/api/atom_api_web_contents.cc
There was a problem hiding this comment.
#309 was merged into 4.4 so this isn't a cr62 issue
bridiver
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#11330
Auditors: @brividr, @bsclifton, @bbondy