Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browserleaks.com/dns manual test to the desktop runs, to ensure we don't leak ISP resolver when using DoH #235

Closed
stephendonner opened this issue Feb 24, 2021 · 0 comments
Closed

Add browserleaks.com/dns manual test to the desktop runs, to ensure we don't leak ISP resolver when using DoH #235

stephendonner opened this issue Feb 24, 2021 · 0 comments
Assignees
@stephendonner

Comments

@stephendonner
Copy link
Contributor

stephendonner commented Feb 24, 2021 •
edited
Loading

As discussed in the post-mortem, we should add a manual check -- at least for desktop, and probably for Android/iOS? -- that using DNS-over-HTTP (DoH), we don't leak the ISP DNS resolver.

We'll use https://browserleaks.com/dns and add it to the manual checks for both desktop (https://github.com/brave/qa-resources/blob/master/wikitemplate.md) and Android (https://github.com/brave/qa-resources/blob/master/wikitemplate-android.md)

Cross-reference: brave/brave-browser#12575

/cc @kjozwiak
@stephendonner stephendonner self-assigned this Feb 27, 2021
stephendonner added a commit that referenced this issue Mar 1, 2021
@stephendonner
Merge pull request #236 from stephendonner/add-dns-leak-test
8420fe6 
Add DNS leak tests for desktop and Android; fixes issue #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephendonner stephendonner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephendonner