Add DNS leak tests for desktop and Android; fixes issue #235 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
Feb 27, 2021
diracdeltas
approved these changes
Feb 27, 2021
stephendonner
changed the title
kjozwiak
requested changes
Mar 1, 2021
There was a problem hiding this comment.
@stephendonner looking good 👍 Just a small nit. Lets follow the format of adding links into code formatting.. Example:
https://browserleaks.com/dns vs https://browserleaks.com/dns
Fixes #235; adds test steps for verifying we don't leak ISP resolvers when using DoH. Add test for Android to verify we don't leak ISP DNS resolvers using DoH. Fixes #235; adds test steps for verifying we don't leak ISP DNS resolvers when using DoH. Add DNS-leak test for Tor windows. Added New Private Window with Tor DNS-leak test. Fix link style Fix link style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried for parity, but Android doesn't have the scheme handler that we do on desktop, and perfect is the enemy of good.
I'll squash commits before merging, once approved.
r? @kjozwiak @diracdeltas @srirambv?