Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test for unimplemented public-gateway on Android #466

Closed
stephendonner opened this issue Aug 31, 2022 · 1 comment
Closed

Remove test for unimplemented public-gateway on Android #466

stephendonner opened this issue Aug 31, 2022 · 1 comment
Assignees
@stephendonner
Labels
OS/Android testsheet

Comments

@stephendonner
Copy link
Contributor

Remove the following test[0] from the IPFS on Android section:

Verify you can't change the IPFS public gateway address to https://cloudflare-ipfs.com/ (An error Only a valid IPFS gateway with Origin isolation enabled can be used in Brave is displayed – brave/brave-browser#18212 (comment)).

We don't have the ability, currently, in Android, to specify an alternate public-gateway URL.

[0] https://github.com/brave/qa-resources/blob/82e6e8dd508f87595b20c4bbde093cd80d124dbe/wikitemplate-IPFS.md#public-gateway-setting
@stephendonner stephendonner self-assigned this Aug 31, 2022
stephendonner added a commit that referenced this issue Aug 31, 2022
@stephendonner
Remove unnecessary test; fixes issue #466
a4e7dc2
stephendonner added a commit that referenced this issue Aug 31, 2022
@stephendonner
Merge pull request #467 from brave/fix_466
070a123 
Remove unnecessary test; fixes issue #466
@stephendonner
Copy link
Contributor Author

Fixed by #467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephendonner stephendonner

Labels
OS/Android testsheet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephendonner