Remove unnecessary test; fixes issue #466 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srirambv
reviewed
Sep 1, 2022
| @@ -256,7 +256,6 @@ | |||
| - [ ] Verify the setting is enabled by default. | |||
| - [ ] Verify disable/enable setting is retained between browser launch/restarts. | |||
| - [ ] Verify setting state is retained during upgrade. | |||
| - [ ] Verify you can't change the IPFS public gateway address to `https://cloudflare-ipfs.com/` (An error `Only a valid IPFS gateway with Origin isolation enabled can be used in Brave` is displayed – [example](https://github.com/brave/brave-browser/issues/18212#issuecomment-923632150)). | |||
| - [ ] Verify you can change the IPFS public gateway address to `https://cf-ipfs.com/` (passes the Origin isolation test). | |||
There was a problem hiding this comment.
Probably should remove this as well as this is not applicable to Android either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPFS Gatewayis currently just anEnabled/Disabledtoggle.Remove its test.