Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording of one fingerprinting test #335

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Fix wording of one fingerprinting test #335

merged 2 commits into from
Jul 20, 2021

Conversation

stephendonner
Copy link
Contributor

@stephendonner stephendonner commented Jul 15, 2021 •
edited by srirambv
Loading

Fixes #338

srirambv
srirambv requested changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be updated for the Android template file so please make the change there as well

wikitemplate.md Outdated Show resolved Hide resolved
kjozwiak
kjozwiak approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stephendonner stephendonner merged commit aec2f93 into brave:master Jul 20, 2021
@stephendonner stephendonner deleted the fix-fingerprinting-text branch July 20, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@stephendonner stephendonner

Labels
testsheet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix WebRTC Fingerprinting test
3 participants
@stephendonner @kjozwiak @srirambv