Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording of one fingerprinting test #335

Merged
merged 2 commits into from
Jul 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wikitemplate-android.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Pre-Requisite: Put previous build shortcut on the home screen. Also, have severa
- [ ] Run all six test configurations on `https://dev-pages.brave.software/storage/ephemeral-storage.html` and confirm results are as expected per each test listed.
### Fingerprint Tests
- [ ] Visit `https://browserleaks.com/webrtc`, ensure 2 blocked items are listed in shields
- [ ] Verify that `https://diafygi.github.io/webrtc-ips/` doesn't leak IP address when `Block all fingerprinting protection` is on
- [ ] Test that https://diafygi.github.io/webrtc-ips/ doesn't leak IP address for each option under `Settings -> Privacy and Security -> WebRTC IP handling policy`

## Content Tests

Expand Down
6 changes: 3 additions & 3 deletions wikitemplate.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
- [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in Shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00`
- [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ only when `Block all fingerprinting protection` is on
- [ ] Test that Brave browser isn't detected via user-agent, on https://www.whatismybrowser.com. The site **will** say "Looks like Brave on [Windows/Linux/macOS]", and yet, "But it's announcing that it's Chrome [version] on [platform]"
- [ ] Test that https://diafygi.github.io/webrtc-ips/ doesn't leak IP address when `Block all fingerprinting protection` is on
- [ ] Test that https://diafygi.github.io/webrtc-ips/ doesn't leak IP address for each option under `Settings -> Privacy and Security -> WebRTC IP handling policy`

### Brave Ads

Expand Down Expand Up @@ -238,6 +238,6 @@

## Hardware Wallet Test (To be checked on each major CR bump)

- [ ] Verify you can link hardware wallet using Trezor and unlock the wallet
- [ ] Verify you can link hardware wallet using Trezor and unlock the wallet
- [ ] Verify you can link hardware wallet using Ledger Nano and unlock the wallet
- [ ] Verify you can perform a transaction with hardware wallet using Ledger Nano or Trezor
- [ ] Verify you can perform a transaction with hardware wallet using Ledger Nano or Trezor