Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename output field credit to meta, adjust types, etc. #4

Closed
brev opened this issue Oct 31, 2023 · 0 comments
Closed

Rename output field credit to meta, adjust types, etc. #4

brev opened this issue Oct 31, 2023 · 0 comments
Assignees
@brev
Labels
enhancement New feature or request

Comments

@brev
Copy link
Owner

brev commented Oct 31, 2023 •
edited
Loading

Rename output field credit to meta, adjust types, etc.

Details: PR #5
@brev brev self-assigned this Oct 31, 2023
@brev brev added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 31, 2023
brev added a commit that referenced this issue Nov 3, 2023
@brev
Deprecate web-image-gen-common npm package.
430cf70 
- Move code to pkgs that use it.
- Move types to pkgs that use them.
- Only thing remains is truly common types.
- `common` dir no longer used as pkg, but via symlinks.
- `ImageSet` type is re-exported by other pkgs.
- `Credit` and `Meta` types deprecated, user can type their own
  metadata json.

Issue #4
brev added a commit that referenced this issue Nov 3, 2023
@brev
CLI - Deprecate web-image-gen-common usage.
1615bce 
- Move core defines and helpers over from `common`.
- Move some types over from `common`, and symlink the shared remnants.
  - Symlink `ImageSet` type from `common`.
- Add new example non-credit metadata field to docs and test stubs.
- Renamed some test libs for sanity.
- Dependency updates.

Issue #4.
brev added a commit that referenced this issue Nov 3, 2023
@brev
Svelte component: Deprecate web-image-gen-common.
b09b804 
- Get and re-export `ImageSet` type via symlink to `common`
- Drop `Credit` and `Meta` types, developer can type metadata on their side.
- Add example non-credit `description` metadata field to docs and test stubs.
- Use `mime` package to get `Content-Type` strings, remove hard-coded list.
- Exclude tests in tsconfig. Test files still getting copied to output
  `dist/` though, I think a bug/feature of `svelte-package`, @todo
  later.
- Add sveltekit aliases to tsconfig.
- Dependecy updates.

Fixes Issue #4.
@brev brev mentioned this issue Nov 3, 2023
Merged
@brev brev changed the title Rename credit to meta, adjust types, etc. Rename output field credit to meta, adjust types, etc. Nov 4, 2023
@brev brev closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brev brev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brev