Breaking! Rename credit field in output manifest to meta, and deprecate types.
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move code to pkgs that use it. - Move types to pkgs that use them. - Only thing remains is truly common types. - `common` dir no longer used as pkg, but via symlinks. - `ImageSet` type is re-exported by other pkgs. - `Credit` and `Meta` types deprecated, user can type their own metadata json. Issue #4
- Move core defines and helpers over from `common`. - Move some types over from `common`, and symlink the shared remnants. - Symlink `ImageSet` type from `common`. - Add new example non-credit metadata field to docs and test stubs. - Renamed some test libs for sanity. - Dependency updates. Issue #4.
- Get and re-export `ImageSet` type via symlink to `common` - Drop `Credit` and `Meta` types, developer can type metadata on their side. - Add example non-credit `description` metadata field to docs and test stubs. - Use `mime` package to get `Content-Type` strings, remove hard-coded list. - Exclude tests in tsconfig. Test files still getting copied to output `dist/` though, I think a bug/feature of `svelte-package`, @todo later. - Add sveltekit aliases to tsconfig. - Dependecy updates. Fixes Issue #4.
brev
changed the title
credit to metadatacredit output field to meta and deprecate types.
brev
changed the title
credit output field to meta and deprecate types.credit field in output manifest to meta, and deprecate types.
brev
changed the title
credit field in output manifest to meta, and deprecate types.credit field in output manifest to meta, and deprecate types.
brev
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes! Versions bumped to
2.0.0.Rename
creditfield in output object tometa, and deprecate types.web-image-gen-commonpublic package, now private, and used via symlinks instead of workspaces or npm. Can't figure out ideal solution to have shared types in a monorepo (usually workspaces or typescript project references), but where those types are also to be exported out to the world.CreditandMetatypes. Developer can type on their side.ImageSettype is available from bothcliandsveltepackages.--loaderto new--import/register()usage.Fixes Issue #4