add disable_os_default recipe #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alepore
force-pushed
the
disable_os_default
branch
from
f380a9b to
1efdaea
Compare
| recipe "redisio::redis_gem", "this recipe will install the redis ruby gem into the system ruby" | ||
| recipe "redisio::disable", "This recipe is used to stop the redis instances and disable them in the default run levels" | ||
| recipe "redisio::redis_gem", "This recipe will install the redis ruby gem into the system ruby" | ||
| recipe "redisio::disable_os_default", "This recipe can be used to disable the default OS redis init scrip" |
There was a problem hiding this comment.
typo at the end scrip
alepore
force-pushed
the
disable_os_default
branch
from
1efdaea to
2a52f6c
Compare
|
rebased and updated |
|
👍 I'm good with this |
Closed
|
|
||
| if service_name | ||
| service service_name do | ||
| action :disable |
There was a problem hiding this comment.
action [ :stop, :disable ]
|
Hit this earlier today. Added the service resource with suggestions by @shortdudey123 to my wrapper script. This PR probably needs a re-base, then 👍 from me |
|
@alepore Can you rebase this for a merge ? |
alepore
force-pushed
the
disable_os_default
branch
from
2a52f6c to
3d34784
Compare
|
updated and rebased! |
|
alepore
force-pushed
the
disable_os_default
branch
from
3d34784 to
d7c831b
Compare
|
rubocop 🆗 |
|
awesome! looking good to me :) |
|
Thanks all involved for pushing this through. |
shortdudey123
added a commit
that referenced
this pull request
May 10, 2017
- Update 'bind' config comments ([#293](#293)) - Add disable_os_default recipe ([#224](#224)) - Use the config's ulimits if set and is > max_clients ([#234](#234)) - Add Travis config ([#299](#299)) - Fix test failures (FoodCritic and Rubocop) ([#298](#298)) - Fix TravisCI builds ([#300](#300)) - Add repl-backlog-size, repl-backlog-ttl, and aof-load-truncated options ([#278](#278)) - Add sentinel_bind to bind sentinel to different IPs ([#306](#306)) - Cleanup deprecation warnings ([#301](#301)) - Fix version detection with epoch version numbers from deb/ubuntu ([#294](#294)) - Restrict VM redis config to <= 2.4 ([#322](#322)) - Rename_commands should be checked for nil before empty ([#311](#311)) - Fixup foodcritic, rubocop, and kitchen testing ([#324](#324)) - Note: this drops support for Chef < 11 - Add min-slaves redis options ([#313](#313)) - Allow /etc/init start after sigterm from system or user ([#310](#310)) - Check user existence with Etc, not ohai node attributes ([#303](#303)) - Various systemd-related improvements ([#302](#302)) - Update serverspec testing with correct OS's for systemd ([#329](#329)) - Add kitchen-dokken testing to Travis ([#330](#330)) - Add fedora-25 to kitchen testing and clean up kitchen config ([#331](#331)) - Fix systemd paths for sentinel service ([#332](#332)) - Add redis-package and sentinel to Travis kitchen verify ([#334](#334)) - Add breadcrumb-file creation condition as attribute ([#268](#268)) - Fix cluster options in README ([#333](#333)) - Fix systemd loader to use descriptors instead of max_clients+32 ([#338](#338)) - Add SELinux support ([#305](#305)) - Make source of redis.conf template configurable ([#341](#341)) - Support sentinel notification-script and client-reconfig-script ([#342](#342))
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using redis from the ubuntu package, i use this simple recipe to disable the default OS init script.
Otherwise i can't use the init script provided by this recipe after a reboot.
Do you think something like this can be a useful addition?