use the config's ulimits if set and is > max_clients.

[popsikle]

I spent a bit trying to figure out why setting config['ulimit'] was capping out at 10k (max_clients). This fixes that, which lets someone control ulimits on the redis user while protecting against too small of a ulimit.

[majuscule]

+1 for this merge. The ulimit also needs to be set in the unit file from recipes/configure.rb for systemd machines. I'd be happy to make the changes once this is merged... Until then, for anyone who finds this, the solution is a drop-in (described in systemd.unit(5)):

node['redisio']['servers'].each do |service|
    if service.has_key?('ulimit')
        directory "/usr/lib/systemd/system/redis@#{service['port']}.service.d/"
        template "/usr/lib/systemd/system/redis@#{service['port']}.service.d/limits.conf" do
            source 'limits.conf.erb'
            variables({ :ulimit => service['ulimit'] })
            notifies :run, 'execute[systemctl-daemon-reload]', :immediately
        end
    end
end

execute 'systemctl-daemon-reload' do
  command '/bin/systemctl daemon-reload'
  action :nothing
end

[Service]
LimitNOFILES=<%= @ulimit %>

[popsikle]

sigh

[brianbianco]

Frankly I don't find adding Sigh to a pull request as constructive in the least. While it did draw my attention to the fact that this needs to be merged, I found it to be a bit inconsiderate.

@majuscule Would you mind doing a PR for your additions after I merge this?

[majuscule]

Hey @brianbianco. I'm no longer using chef day to day. I'd be happy to drop these additions into the install script, but I don't have a proper environment to test the changes. I took a quick look and noticed there is already

templates/default/redis@.service.erb
10:LimitNOFILE=<%= @limit_nofile %>

from commit e6468d0, so it looks like someone already implemented the fix without merging this pull request :-(.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.