Added breadcrumb-file creation condition as attribute #268
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't familiar with redis-sentinel so I was quite surprised that my configuration file was not updated by Chef. Please make this optional. |
|
@chewi @shortdudey123 could you take a look to this PR. We have to use own fork due to such limitation. |
|
@paulpalamarchuk can you rebase on master? |
|
@shortdudey123 rebased |
shortdudey123
suggested changes
Apr 27, 2017
README.md
Outdated
| @@ -366,7 +381,9 @@ Available options and their defaults | |||
| 'cluster-enabled' => 'no', | |||
| 'cluster-config-file' => nil, # Defaults to redis instance name inside of template if cluster is enabled. | |||
| 'cluster-node-timeout' => 5000, | |||
| 'includes' => nil | |||
| 'includes' => nil, | |||
| 'breadcrumb' => true # Defaults to create breadcrumb lock-file. | |||
There was a problem hiding this comment.
Can you fix the spacing here?
|
small nit pick in spacing then will merge |
|
@shortdudey123 done |
|
thanks! |
|
thank you all! 😄 |
shortdudey123
added a commit
that referenced
this pull request
May 10, 2017
- Update 'bind' config comments ([#293](#293)) - Add disable_os_default recipe ([#224](#224)) - Use the config's ulimits if set and is > max_clients ([#234](#234)) - Add Travis config ([#299](#299)) - Fix test failures (FoodCritic and Rubocop) ([#298](#298)) - Fix TravisCI builds ([#300](#300)) - Add repl-backlog-size, repl-backlog-ttl, and aof-load-truncated options ([#278](#278)) - Add sentinel_bind to bind sentinel to different IPs ([#306](#306)) - Cleanup deprecation warnings ([#301](#301)) - Fix version detection with epoch version numbers from deb/ubuntu ([#294](#294)) - Restrict VM redis config to <= 2.4 ([#322](#322)) - Rename_commands should be checked for nil before empty ([#311](#311)) - Fixup foodcritic, rubocop, and kitchen testing ([#324](#324)) - Note: this drops support for Chef < 11 - Add min-slaves redis options ([#313](#313)) - Allow /etc/init start after sigterm from system or user ([#310](#310)) - Check user existence with Etc, not ohai node attributes ([#303](#303)) - Various systemd-related improvements ([#302](#302)) - Update serverspec testing with correct OS's for systemd ([#329](#329)) - Add kitchen-dokken testing to Travis ([#330](#330)) - Add fedora-25 to kitchen testing and clean up kitchen config ([#331](#331)) - Fix systemd paths for sentinel service ([#332](#332)) - Add redis-package and sentinel to Travis kitchen verify ([#334](#334)) - Add breadcrumb-file creation condition as attribute ([#268](#268)) - Fix cluster options in README ([#333](#333)) - Fix systemd loader to use descriptors instead of max_clients+32 ([#338](#338)) - Add SELinux support ([#305](#305)) - Make source of redis.conf template configurable ([#341](#341)) - Support sentinel notification-script and client-reconfig-script ([#342](#342))
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.