Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures (FoodCritic and Rubocop) #298

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Fix test failures (FoodCritic and Rubocop) #298

merged 2 commits into from
Oct 25, 2016

Conversation

shortdudey123
Copy link
Contributor

No description provided.

@devsibwarra
Copy link

👍

@shortdudey123
Copy link
Contributor Author

rebased on master and fixed another rubocop offense that got in after i branched off

devsibwarra
devsibwarra suggested changes Oct 20, 2016
View reviewed changes
providers/configure.rb
descriptors = current['ulimit']
else
descriptors = current['maxclients']
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a few pieces here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@devsibwarra
Copy link

Looks good from my perspective

brianbianco
brianbianco reviewed Oct 20, 2016
View reviewed changes
providers/configure.rb
:unixsocket => current['unixsocket']
})
only_if { node['redisio']['job_control'] == 'rcinit' }
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something here, Why were so many variables removed from this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing they were unused in the template, which is a rubocop complaint I've had with my own code and a newer rubocop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables that were removed are unused and tripped FC034

@brianbianco
Copy link
Contributor

Ok thanks. I should pay better attention. I wonder why they were added in the first place. This looks good for a merge.

@shortdudey123
Copy link
Contributor Author

No problem and cool

@shortdudey123
Copy link
Contributor Author

@brianbianco any final thoughts before merging? :)

@martinb3
Copy link
Contributor

LGTM 👍

@brianbianco brianbianco merged commit a80931f into sous-chefs:master Oct 25, 2016
@brianbianco
Copy link
Contributor

Thanks again @shortdudey123

@shortdudey123 shortdudey123 deleted the fix_test_failures branch October 25, 2016 16:11
@shortdudey123 shortdudey123 added this to the 2.6.0 milestone Apr 25, 2017
shortdudey123 added a commit that referenced this pull request May 10, 2017
@shortdudey123
Release 2.6.0
545c5f6 
- Update 'bind' config comments ([#293](#293))
- Add disable_os_default recipe ([#224](#224))
- Use the config's ulimits if set and is > max_clients ([#234](#234))
- Add Travis config ([#299](#299))
- Fix test failures (FoodCritic and Rubocop) ([#298](#298))
- Fix TravisCI builds ([#300](#300))
- Add repl-backlog-size, repl-backlog-ttl, and aof-load-truncated options ([#278](#278))
- Add sentinel_bind to bind sentinel to different IPs ([#306](#306))
- Cleanup deprecation warnings ([#301](#301))
- Fix version detection with epoch version numbers from deb/ubuntu ([#294](#294))
- Restrict VM redis config to <= 2.4 ([#322](#322))
- Rename_commands should be checked for nil before empty ([#311](#311))
- Fixup foodcritic, rubocop, and kitchen testing ([#324](#324))
  - Note: this drops support for Chef < 11
- Add min-slaves redis options ([#313](#313))
- Allow /etc/init start after sigterm from system or user ([#310](#310))
- Check user existence with Etc, not ohai node attributes ([#303](#303))
- Various systemd-related improvements ([#302](#302))
- Update serverspec testing with correct OS's for systemd ([#329](#329))
- Add kitchen-dokken testing to Travis ([#330](#330))
- Add fedora-25 to kitchen testing and clean up kitchen config ([#331](#331))
- Fix systemd paths for sentinel service ([#332](#332))
- Add redis-package and sentinel to Travis kitchen verify ([#334](#334))
- Add breadcrumb-file creation condition as attribute ([#268](#268))
- Fix cluster options in README ([#333](#333))
- Fix systemd loader to use descriptors instead of max_clients+32 ([#338](#338))
- Add SELinux support ([#305](#305))
- Make source of redis.conf template configurable ([#341](#341))
- Support sentinel notification-script and client-reconfig-script ([#342](#342))
@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devsibwarra devsibwarra devsibwarra requested changes

@brianbianco brianbianco brianbianco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shortdudey123 @devsibwarra @brianbianco @martinb3