7.0 #1369
Merged
7.0 #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unsupported Node versions 0.10 and 0.12 from CI * Replace deprecated Buffer constructor with .from/.alloc * Remove Promise polyfill * Make use of Object.assign * Remove checks for versions of Node earlier than 4 * Remove Buffer#indexOf fallback for Node 0.10
* Add client connectionString tests (#1310) * Remove redundant tests * Add client connectionString test Add test to ensure { connectionString } is respected as an argument to the client constructor * Add test for connection string property Also fixed some legacy require statements. * Normalize native error properties Map native error properties to the same property names we use for errors from the JS driver. Fixes #972 Fixes #938
Removes the default node 6 / PG 9.6 combination and adds it to the Travis-CI matrix of combinations. That way all combinations are defined in a single place.
Make file paths more closely match the non-native files, to make auto-complete file names slightly easier.
Passing nothing for both the query.text and query.name is unsupported but previously crashed with an impossible to catch error.
Clients are not reusable. This changes the client to raise errors whenever you try to reconnect a client that's already been used. They're cheap to create: just instantiate a new one (or use the pool) 😉. Closes #1352
This is a small change and is _kinda_ backwards compatible since the old behavior was to throw an error, but if someone was relying on anything with `.map` working as values it would break them, so it's in a major semver bump.
* Work on converting lib to standard * Finish updating lib * Finish linting lib * Format test files * Add .eslintrc with standard format * Supply full path to eslint bin * Move lint command to package.json * Add eslint as dev dependency
|
Amazing ! |
|
Excellent work! this is exactly the kind of list I was looking for! |
This one is the mega bonus / christmas gift 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable breaking changes:
client.queryno longer returns an event-emitter. If a callback is supplied, it returns undefined. If no callback is supplied it returns aPromise.This was deprecated inpg@6.xpg.connectandpg.endglobal singleton pool was removed. This was deprecated inpg@6.xpg.cancelwhich used the global singleton pool was removed. This was deprecated in pg@6.x`pg.nativeand checking error feilds such aserror.contextorerror.wherechangeEnhancements:
connectionTimeoutMillisfor a connection timeout feature in the pool