Support TCP keepalives similarly to libpq

[motiz88]

This depends on iceddev/pg-connection-string#7 (which is why the tests don't pass yet) and would fix #909. Tested in production in my project. This is a more fleshed-out solution than #918.

I'd appreciate a comment from a maintainer here in support of the pg-connection-string PR, so that it gets merged there, after which the tests here can be re-run and the PR merged.

[motiz88]

@brianc? Anyone?

[jspavlick]

+1

[brianc]

Hey @motiz88 sorry for missing this - currently the tests are failing & the PR wont cleanly merge. I really appreciate the thought you put in here...I've been busy w/ some life stuff & just now returning to computer-world. Do you think you could get the tests to pass & rebase your changes onto current master & resolve conflicts? Afterwards i'll happily merge & push a new minor version.

[motiz88]

I'd love to. If I don't get around to it in a week or so, please feel free
to ping me about it!
On Apr 28, 2016 10:53 PM, "Brian C" notifications@github.com wrote:

Hey @motiz88 https://github.com/motiz88 sorry for missing this -
currently the tests are failing & the PR wont cleanly merge. I really
appreciate the thought you put in here...I've been busy w/ some life stuff
& just now returning to computer-world. Do you think you could get the
tests to pass & rebase your changes onto current master & resolve
conflicts? Afterwards i'll happily merge & push a new minor version.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#928 (comment)

[NumminorihSF]

@brianc, can you close #948, #918, #913 if you will merge this?

[brianc]

This looks like it'll merge cleanly, but all the tests are still failing. 😦 If they pass I'd happily merge it in!

[brianc]

Support will be merged in with pg@6.0.0 for this feature! Thanks for taking the time to report it & put thought & work into it!! 👏