Copy all but special-cased params from URL query string to config #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's pretty cool. Can you open an issue on https://github.com/brianc/node-postgres and link it back here. I always make sure to get visibility from the main community using this before adopting changes. |
|
Can we merge this in? If I understand change correctly, it just copies most of querystring parameters into output? Also relevant: brianc/node-postgres#1095 |
| delete result.query[key]; | ||
| }); | ||
|
|
||
| Object.getOwnPropertyNames(result.query).forEach(function(key) { |
There was a problem hiding this comment.
Object.getOwnPropertyNames is not available in 0.10 and 0.12, so probably change it to Object.keys?
This was referenced Aug 31, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This semver-minor change is an alternative to whitelisting each individual Postgres parameter.
The "whitelist" approach can and does coexist with this change, in the special handling of
"ssl". In my view, future work can still add special handling for more params based on their types as listed in the Postgres docs, but clients must always also be able to deal with raw strings.