Add extra_float_digits parameter parsing #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like some follow up by the maintainers on your node-postgres issue before I merge this. @brianc thoughts? |
|
Let's merge #7 instead? White-listing isn't best option here overall, I think, since server rejects invalid options already, and it is substantially more hassle trying to keep up with all the params supported (and changing them in short time). |
|
#11 does this more generally |
|
@sehrope @elmigranto @caub You good with closing this since #11 has been merged? |
|
@sehrope Closing this as I think this issue is solved. Please ping back if there is still an outstanding issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls
extra_float_digitsfrom the query portion of the connection URI and if exists, populates it on the returned config object.This is needed in node-postgres to eventually allow specifying a custom value for it.