Skip to content

Add extra_float_digits parameter parsing #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sehrope
Copy link

@sehrope sehrope commented Apr 5, 2015

This PR pulls extra_float_digits from the query portion of the connection URI and if exists, populates it on the returned config object.

This is needed in node-postgres to eventually allow specifying a custom value for it.

@phated
Copy link

phated commented Apr 5, 2015

I'd like some follow up by the maintainers on your node-postgres issue before I merge this.

@brianc thoughts?

@elmigranto
Copy link

Let's merge #7 instead? White-listing isn't best option here overall, I think, since server rejects invalid options already, and it is substantially more hassle trying to keep up with all the params supported (and changing them in short time).

@caub
Copy link
Contributor

caub commented Jul 1, 2017

#11 does this more generally

@monteslu
Copy link
Member

@sehrope @elmigranto @caub You good with closing this since #11 has been merged?

@hjr3
Copy link
Contributor

hjr3 commented May 23, 2019

@sehrope Closing this as I think this issue is solved. Please ping back if there is still an outstanding issue.

@hjr3 hjr3 closed this May 23, 2019
@sehrope sehrope deleted the extra-float-digits branch May 23, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants