LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null

[liferay-continuous-integration]

Forwarded from: liferay-headless#2524 (Took 2 ci:forward attempts in 5 hours 42 minutes)
Console

@jonathanmccann
@liferay-headless

Original pull request comment:

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-47903

How am I fixing it?

Previously reviewed liferay-headless#2502
Resending with requested changes from #158550 (comment)

In certain cases httpURLConnection.getErrorStream() can return null as defined in the spec - https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/HttpURLConnection.html#getErrorStream()

This was caught in one of Site Management's tests where we expect the action to fail and confirm it fails with the correct status code.

I updated the template to only process the inputStream if it exists. Please let me know your thoughts on the change and if you see an alternative approach that you would prefer instead. Thank you.

How can you verify that it works?

In headless-site-test run gw testIntegration --tests *.SiteResourceTest
In petra-http-invoker run gw test --tests "HttpInvokerTest"

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 93ef501e569609909bd960ab12a448298d442074

Sender Branch:

Branch Name: LPD-47903
Branch GIT ID: 9d16d885ea24d6bba26c4813097df39b9248f8d5

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

[liferay-continuous-integration]

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 103 out of 143 jobs passed in 3 hours 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 93ef501e569609909bd960ab12a448298d442074

Upstream Comparison:

Branch GIT ID: 93ef501e569609909bd960ab12a448298d442074
Jenkins Build URL: EE Development Acceptance (master) - 1171 - 2025-02-06[12:38:09]

ci:test:stable - 25 out of 25 jobs PASSED

25 Successful Jobs:

ci:test:relevant - 103 out of 143 jobs PASSED

40 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• central-requirements
  • central-requirements/0/0
• functional-smoke-tomcat90-mysql57_stable
  • functional-smoke-tomcat90-mysql57_stable/0/0
• functional-upgrade-tomcat90-mysql57_stable
  • functional-upgrade-tomcat90-mysql57_stable/0/0
  • functional-upgrade-tomcat90-mysql57_stable/0/1
  • functional-upgrade-tomcat90-mysql57_stable/0/2
• js-unit
  • js-unit/0/0
  • js-unit/1/0
• modules-compile
  • modules-compile/0/0
  • modules-compile/0/1
  • modules-compile/0/2
  • modules-compile/0/3
  • modules-compile/0/4
  • modules-compile/0/5
  • modules-compile/0/6
  • modules-compile/0/7
  • modules-compile/0/8
  • modules-compile/0/9
  • modules-compile/0/10
  • modules-compile/0/11
  • modules-compile/0/12
• modules-integration-mysql57
  • modules-integration-mysql57/0/0
  • modules-integration-mysql57/0/1
  • modules-integration-mysql57/0/2
  • modules-integration-mysql57/0/3
  • modules-integration-mysql57/0/4
  • modules-integration-mysql57/0/5
  • modules-integration-mysql57/0/6
  • modules-integration-mysql57/0/7
  • modules-integration-mysql57/0/8
  • modules-integration-mysql57/0/9
  • modules-integration-mysql57/0/10
  • modules-integration-mysql57/0/11
  • modules-integration-mysql57/0/12
  • modules-integration-mysql57/0/13
  • modules-integration-mysql57/0/14
  • modules-integration-mysql57/0/15
  • modules-integration-mysql57/0/16
  • modules-integration-mysql57/0/17
  • modules-integration-mysql57/0/18
  • modules-integration-mysql57/0/19
  • modules-integration-mysql57/0/20
  • modules-integration-mysql57/0/21
  • modules-integration-mysql57/0/22
  • modules-integration-mysql57/0/23
  • modules-integration-mysql57/0/24
  • modules-integration-mysql57/1/0
  • modules-integration-mysql57/1/1
  • modules-integration-mysql57/1/2
  • modules-integration-mysql57/1/3
  • modules-integration-mysql57/1/4
  • modules-integration-mysql57/1/5
  • modules-integration-mysql57/1/6
  • modules-integration-mysql57/1/7
  • modules-integration-mysql57/1/8
  • modules-integration-mysql57/1/9
  • modules-integration-mysql57/1/10
  • modules-integration-mysql57/1/11
  • modules-integration-mysql57/1/12
  • modules-integration-mysql57/1/13
  • modules-integration-mysql57/1/14
  • modules-integration-mysql57/1/15
  • modules-integration-mysql57/1/16
  • modules-integration-mysql57/1/17
  • modules-integration-mysql57/1/18
  • modules-integration-mysql57/1/19
  • modules-integration-mysql57/1/20
  • modules-integration-mysql57/1/21
  • modules-integration-mysql57/1/22
  • modules-integration-mysql57/1/23
  • modules-integration-mysql57/1/24
  • modules-integration-mysql57/2/0
  • modules-integration-mysql57/2/1
  • modules-integration-mysql57/2/2
  • modules-integration-mysql57/2/3
  • modules-integration-mysql57/2/4
  • modules-integration-mysql57/2/5
  • modules-integration-mysql57/2/6
  • modules-integration-mysql57/2/7
  • modules-integration-mysql57/2/8
  • modules-integration-mysql57/2/9
  • modules-integration-mysql57/2/10
  • modules-integration-mysql57/2/11
  • modules-integration-mysql57/2/12
  • modules-integration-mysql57/2/13
  • modules-integration-mysql57/2/14
  • modules-integration-mysql57/2/15
  • modules-integration-mysql57/2/16
  • modules-integration-mysql57/2/17
  • modules-integration-mysql57/2/18
  • modules-integration-mysql57/2/19
  • modules-integration-mysql57/2/20
  • modules-integration-mysql57/2/21
  • modules-integration-mysql57/2/22
  • modules-integration-mysql57/2/23
  • modules-integration-mysql57/2/24
  • modules-integration-mysql57/3/0
  • modules-integration-mysql57/3/1
  • modules-integration-mysql57/3/2
  • modules-integration-mysql57/3/3
  • modules-integration-mysql57/3/4
  • modules-integration-mysql57/3/5
  • modules-integration-mysql57/3/6
  • modules-integration-mysql57/3/7
  • modules-integration-mysql57/3/8
  • modules-integration-mysql57/3/9
  • modules-integration-mysql57/3/10
  • modules-integration-mysql57/3/11
  • modules-integration-mysql57/3/12
  • modules-integration-mysql57/3/13
  • modules-integration-mysql57/3/14
  • modules-integration-mysql57/3/15
  • modules-integration-mysql57/3/16
  • modules-integration-mysql57/3/17
  • modules-integration-mysql57/3/18
  • modules-integration-mysql57/3/19
  • modules-integration-mysql57/3/20
  • modules-integration-mysql57/3/21
  • modules-integration-mysql57/3/22
  • modules-integration-mysql57/3/23
  • modules-integration-mysql57/3/24
  • modules-integration-mysql57/4/0
  • modules-integration-mysql57/4/1
  • modules-integration-mysql57/4/2
  • modules-integration-mysql57/4/3
  • modules-integration-mysql57/4/4
  • modules-integration-mysql57/4/5
  • modules-integration-mysql57/4/6
  • modules-integration-mysql57/4/7
• modules-integration-mysql57_stable
  • modules-integration-mysql57_stable/0/0
• modules-semantic-versioning
  • modules-semantic-versioning/0/0
• modules-unit
  • modules-unit/0/0
  • modules-unit/0/1
  • modules-unit/0/2
• modules-unit_stable
  • modules-unit_stable/0/0
• playwright-js-tomcat90-mysql57
  • playwright-js-tomcat90-mysql57/0/0
  • playwright-js-tomcat90-mysql57/1/0
  • playwright-js-tomcat90-mysql57/2/0
  • playwright-js-tomcat90-mysql57/3/0
  • playwright-js-tomcat90-mysql57/4/0
• playwright-js-tomcat90-mysql57_stable
  • playwright-js-tomcat90-mysql57_stable/0/0
• rest-builder
  • rest-builder/0/0
• unit_stable
  • unit_stable/0/0

103 Successful Jobs:

For more details click here.

---

Failures unique to this pull:

1. modules-integration-mysql57/0/13

   Build was aborted

   1. com.liferay.portlet.test.InvokerFilterContainerImplTest - Failed 0 of last 22

      1. testRun
   2. com.liferay.portlet.test.PortletBagFactoryTest - Failed 0 of last 23

      1. testRun
   3. com.liferay.portlet.test.PortletURLImplTest - Failed 0 of last 22

      1. testRun
   4. ...
2. modules-integration-mysql57/1/3

   record-testray-logs:
   [beanshell] INFO: Using GOOGLE_APPLICATION_CREDENTIALS=/root/.gcloud/ci-testray.json
   [beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/prepared_s3_logs
   [beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/recorded_logs
   [beanshell] Created cache file in /tmp/jenkins-cached-files/863449111.txt
   [beanshell] Executing commands: git remote -v
   [beanshell] Found Git remotes: github-dev, origin, upstream
   [beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2025-02/test-1-39/test-portal-acceptance-pullrequest(master)/12585/modules-integration-mysql57/1/3/jenkins-console.txt.gz in 277 ms
   [stopwatch] [run.current.job: 2:43.104 sec]
   [beanshell] Created cache file in /tmp/jenkins-cached-files/863449111.txt
   BUILD FAILED
   
   /opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15408: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:7417: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:2398: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:2583: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1119: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build.xml:964: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-common.xml:1698: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-common.xml:1041: Unable to execute Gradle task: setUpLibs.

   1. com.liferay.jenkins.Jenkins

      1. test-portal-acceptance-pullrequest-downstream(master)_modules-integration-mysql57/1
   2. com.liferay.object.internal.field.business.type.test.MultiselectPicklistObjectFieldBusinessTypeTest.testPostMultiselectPicklistAsArrayOfMaps - UNTESTED
   3. com.liferay.object.service.test.ObjectEntryFolderLocalServiceTest.testAddObjectEntryFolder - UNTESTED
   4. ...
3. modules-integration-mysql57/1/6

   record-testray-logs:
   
   [beanshell] INFO: Using GOOGLE_APPLICATION_CREDENTIALS=/root/.gcloud/ci-testray.json
   
   [beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/prepared_s3_logs
   
   [beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/recorded_logs
   
   [beanshell] Created cache file in /tmp/jenkins-cached-files/-1859637193.txt
   
   [beanshell] Executing commands: git remote -v
   
   [beanshell] Found Git remotes: github-dev, origin, upstream
   
   [beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2025-02/test-1-39/test-portal-acceptance-pullrequest(master)/12585/modules-integration-mysql57/1/6/jenkins-console.txt.gz in 266 ms
   
   [stopwatch] [run.current.job: 1:59.575 sec]
   
   [beanshell] Created cache file in /tmp/jenkins-cached-files/-1859637193.txt
   
   BUILD FAILED
   
   /opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15408: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:7417: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:2398: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:2583: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1119: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build.xml:964: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-common.xml:1698: The following error occurred while executing this line:
   
   /opt/dev/projects/github/liferay-portal/build-common.xml:1041: Unable to execute Gradle task: setUpLibs.

   1. com.liferay.jenkins.Jenkins

      1. test-portal-acceptance-pullrequest-downstream(master)_modules-integration-mysql57/1
   2. com.liferay.layout.utility.page.service.persistence.test.LayoutUtilityPageEntryPersistenceTest.testCreate - UNTESTED
   3. com.liferay.layout.utility.page.service.persistence.test.LayoutUtilityPageEntryPersistenceTest.testRemove - UNTESTED
   4. ...
4. modules-integration-mysql57/0/14

   1. com.liferay.portal.workflow.task.web.internal.notification.test.WorkflowTaskUserNotificationHandlerTest - Failed 0 of last 22

      1. testGetLink
   2. com.liferay.commerce.test.CommerceCheckoutTest - Failed 8 of last 23

      1. testIsActivePaymentMethodCommerceCheckoutStepNoPaymentMethods
5. modules-integration-mysql57/1/1

   1. com.liferay.exportimport.test.DummyFolderExportImportTest - Failed 15 of last 21

      1. testExportImportDeletions
      2. testUpdateLastPublishDate
6. ...

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

[brianchandotcom]

Merged. Thank you.