LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null #2502

jonathanmccann · 2025-01-31T22:51:38Z

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-47903

How am I fixing it?

In certain cases httpURLConnection.getErrorStream() can return null as defined in the spec - https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/HttpURLConnection.html#getErrorStream()

This was caught in one of Site Management's tests where we expect the action to fail and confirm it fails with the correct status code.

I updated the template to only process the inputStream if it exists. Please let me know your thoughts on the change and if you see an alternative approach that you would prefer instead. Thank you.

How can you verify that it works?

In headless-site-test run gw testIntegration --tests *.SiteResourceTest

liferay-continuous-integration · 2025-01-31T22:51:42Z

CI is automatically triggering the following test suites:

ci:test:sf

jonathanmccann · 2025-01-31T22:52:15Z

ci:test:relevant

jonathanmccann · 2025-01-31T22:52:29Z

ci:test:site-management

liferay-continuous-integration · 2025-01-31T22:55:21Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 66f99d62f2c96f3635e67a98785c2c309bc1e0c4

Sender Branch:

Branch Name: LPD-47903
Branch GIT ID: 4c46a0e16884c263b35e52d5f0bf5111c4da62c3

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-01-31T22:57:04Z

Jenkins Build:test-portal-source-format#3203

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-headless#2502

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jonathanmccann > liferay-headless - PR#2502 - 2025-01-31[14:51:52]

Testray Build ID:`124882705`

Testray Importer:publish-testray-report#14319

liferay-continuous-integration · 2025-02-01T01:00:03Z

❌ ci:test:site-management - 115 out of 123 jobs passed in 2 hours 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 66f99d62f2c96f3635e67a98785c2c309bc1e0c4

Upstream Comparison:

Branch GIT ID: 66f99d62f2c96f3635e67a98785c2c309bc1e0c4
Jenkins Build URL: EE Development Acceptance (master) - 1158 - 2025-01-31[08:36:12]

ci:test:site-management - 115 out of 123 jobs PASSED

8 Failed Jobs:

115 Successful Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-02-01T01:09:22Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6013

Jenkins Report:jenkins-report.html

Jenkins Suite:site-management

Pull Request:liferay-headless#2502

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:site-management - jonathanmccann > liferay-headless - PR#2502 - 2025-01-31[14:52:42]

Testray Build ID:`125050576`

Testray Importer:publish-testray-report#36069

liferay-continuous-integration · 2025-02-01T01:22:11Z

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 73 out of 93 jobs passed in 2 hours 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 66f99d62f2c96f3635e67a98785c2c309bc1e0c4

Upstream Comparison:

Branch GIT ID: 66f99d62f2c96f3635e67a98785c2c309bc1e0c4
Jenkins Build URL: EE Development Acceptance (master) - 1158 - 2025-01-31[08:36:12]

ci:test:stable - 25 out of 25 jobs PASSED

25 Successful Jobs:

ci:test:relevant - 73 out of 93 jobs PASSED

20 Failed Jobs:

73 Successful Jobs:

For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 66f99d6:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-02-01T01:28:51Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#14422

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-headless#2502

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jonathanmccann > liferay-headless - PR#2502 - 2025-01-31[14:52:32]

Testray Build ID:`125071869`

Testray Importer:publish-testray-report#33514

albertojml · 2025-02-04T10:20:24Z

ci:test:relevant

albertojml

Looks good to me. I've relaunched the tests just to make sure everything is working as expected since it seems the previous execution ran into many issues.

If everything works I will forward it. Thanks!

liferay-continuous-integration · 2025-02-05T21:24:02Z

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 77 out of 102 jobs passed in 3 hours 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5a1b51d1511d7580bf1c1e95834f6ecbb25dcf9a

Upstream Comparison:

Branch GIT ID: 5a1b51d1511d7580bf1c1e95834f6ecbb25dcf9a
Jenkins Build URL: EE Development Acceptance (master) - 1168 - 2025-02-05[00:57:16]

ci:test:stable - 25 out of 25 jobs PASSED

25 Successful Jobs:

ci:test:relevant - 77 out of 102 jobs PASSED

25 Failed Jobs:

77 Successful Jobs:

For more details click here.

Failures unique to this pull:

modules-integration-mysql57/1/24

record-testray-logs: [beanshell] INFO: Using GOOGLE_APPLICATION_CREDENTIALS=/root/.gcloud/ci-testray.json [beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/prepared_s3_logs [beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/recorded_logs [beanshell] Created cache file in /tmp/jenkins-cached-files/1693109501.txt [beanshell] Executing commands: git remote -v [beanshell] Found Git remotes: github-dev, origin, upstream [beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2025-02/test-1-40/test-portal-acceptance-pullrequest(master)/12941/modules-integration-mysql57/1/24/jenkins-console.txt.gz in 324 ms [stopwatch] [run.current.job: 5:50.839 sec] [beanshell] Created cache file in /tmp/jenkins-cached-files/1693109501.txt

BUILD FAILED
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15406: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:7417: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:2398: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:2583: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:1119: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build.xml:964: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build-common.xml:1698: The following error occurred while executing this line:
/opt/dev/projects/github/liferay-portal/build-common.xml:1041: Unable to execute Gradle task: setUpLibs.

com.liferay.jenkins.Jenkins
1. test-portal-acceptance-pullrequest-downstream(master)_modules-integration-mysql57/1
com.liferay.headless.admin.site.resource.v1_0.test.DisplayPageTemplateResourceTest.testDeleteSiteSiteByExternalReferenceCodeDisplayPageTemplate - UNTESTED
com.liferay.headless.admin.site.resource.v1_0.test.DisplayPageTemplateResourceTest.testGetSiteSiteByExternalReferenceCodeDisplayPageTemplate - UNTESTED
...

modules-integration-mysql57/0/6
1. com.liferay.headless.commerce.delivery.cart.resource.v1_0.test.TermResourceTest.testClientSerDesToDTO - UNTESTED
2. com.liferay.headless.commerce.delivery.cart.resource.v1_0.test.TermResourceTest.testClientSerDesToJSON - UNTESTED
3. com.liferay.headless.commerce.delivery.cart.resource.v1_0.test.TermResourceTest.testEscapeRegexInStringFields - UNTESTED
4. ...
modules-integration-mysql57/0/7
1. com.liferay.portal.workflow.kaleo.service.persistence.test.KaleoLogPersistenceTest.testCreate - UNTESTED
2. com.liferay.portal.workflow.kaleo.service.persistence.test.KaleoLogPersistenceTest.testRemove - UNTESTED
3. com.liferay.portal.workflow.kaleo.service.persistence.test.KaleoLogPersistenceTest.testUpdateNew - UNTESTED
4. ...
modules-integration-mysql57/0/10
1. com.liferay.commerce.wish.list.service.internal.model.listener.test.GroupModelListenerTest.testOnBeforeRemove - UNTESTED
2. com.liferay.portal.language.override.service.persistence.test.PLOEntryPersistenceTest.testCreate - UNTESTED
3. com.liferay.portal.language.override.service.persistence.test.PLOEntryPersistenceTest.testRemove - UNTESTED
4. ...
modules-integration-mysql57/0/11
1. com.liferay.dynamic.data.mapping.change.tracking.test.DDMFormInstanceReportTableReferenceDefinitionTest.testDiscardCTEntry - UNTESTED
2. com.liferay.dynamic.data.mapping.upgrade.v3_9_1.test.UpgradeDDMStructureTest.testUpgradeDDMFormFieldOptionsReferences - UNTESTED
3. com.liferay.dynamic.data.mapping.upgrade.v3_9_1.test.UpgradeDDMStructureTest.testUpgradeDDMFormFieldReferences - UNTESTED
4. ...
...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-02-05T21:30:38Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#12941

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-headless#2502

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jonathanmccann > liferay-headless - PR#2502 - 2025-02-05[09:55:59]

Testray Build ID:`129810001`

Testray Importer:publish-testray-report#28181

albertojml · 2025-02-06T08:33:33Z

Failures don't seem related. I'm forwarding it.

albertojml · 2025-02-06T08:33:42Z

ci:forward

liferay-continuous-integration · 2025-02-06T08:33:48Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2025-02-06T08:33:49Z

Skipping previously passed test suites:

ci:test:sf
ci:test:stable

liferay-continuous-integration · 2025-02-06T11:47:53Z

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 78 out of 99 jobs passed in 3 hours 10 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1377401_20218

Base Branch:

Branch Name: master
Branch GIT ID: 551dad365312e3592fd19eaabe2a0ca75d52fa62

Upstream Comparison:

Branch GIT ID: 5a1b51d1511d7580bf1c1e95834f6ecbb25dcf9a
Jenkins Build URL: EE Development Acceptance (master) - 1168 - 2025-02-05[00:57:16]

ci:test:stable - 25 out of 25 jobs PASSED

25 Successful Jobs:

ci:test:relevant - 78 out of 99 jobs PASSED

21 Failed Jobs:

78 Successful Jobs:

For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 5a1b51d:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-02-06T11:53:40Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#20218

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-headless#2502

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jonathanmccann > liferay-headless - PR#2502 - 2025-02-06[00:33:53]

Testray Build ID:`130476448`

Testray Importer:publish-testray-report#43564

albertojml · 2025-02-06T15:00:41Z

ci:forward:force

liferay-continuous-integration · 2025-02-06T15:00:45Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

ci:test:relevant
ci:test:sf
AND If the following test suites pass:
ci:test:stable

liferay-continuous-integration · 2025-02-06T15:00:46Z

Skipping previously completed test suites:

ci:test:relevant
ci:test:sf
AND Skipping previously passed test suites:
ci:test:stable

liferay-continuous-integration · 2025-02-06T15:01:55Z

All required test suite(s) completed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2025-02-06T15:02:47Z

Pull request has been successfully forwarded to brianchandotcom#158550
Console

jonathanmccann requested a review from liferay-headless as a code owner January 31, 2025 22:51

liferay-continuous-integration added ci:test:sf - pending ci:test:site-management - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 31, 2025

liferay-continuous-integration added ci:test:site-management - failure and removed ci:test:site-management - pending labels Feb 1, 2025

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 1, 2025

albertojml self-requested a review February 4, 2025 09:21

albertojml approved these changes Feb 4, 2025

View reviewed changes

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending labels Feb 4, 2025

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 5, 2025

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Feb 6, 2025

liferay-continuous-integration mentioned this pull request Feb 6, 2025

LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null brianchandotcom/liferay-portal#158550

Closed

liferay-continuous-integration added the ci:forward:force label Feb 6, 2025

liferay-continuous-integration closed this Feb 6, 2025

jonathanmccann mentioned this pull request Feb 6, 2025

LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null #2524

Closed

liferay-continuous-integration mentioned this pull request Feb 7, 2025

LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null brianchandotcom/liferay-portal#158601

Closed

LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null #2502

LPD-47903 NPE in HttpInvoker due to httpURLConnection.getErrorStream returning null #2502

Conversation

jonathanmccann commented Jan 31, 2025

What is this trying to solve?

How am I fixing it?

How can you verify that it works?

liferay-continuous-integration commented Jan 31, 2025

jonathanmccann commented Jan 31, 2025

jonathanmccann commented Jan 31, 2025

liferay-continuous-integration commented Jan 31, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 31, 2025

liferay-continuous-integration commented Feb 1, 2025

❌ ci:test:site-management - 115 out of 123 jobs passed in 2 hours 7 minutes

Base Branch:

Upstream Comparison:

8 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Feb 1, 2025

liferay-continuous-integration commented Feb 1, 2025

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 73 out of 93 jobs passed in 2 hours 25 minutes

Base Branch:

Upstream Comparison:

20 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Feb 1, 2025

albertojml commented Feb 4, 2025

albertojml left a comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Feb 5, 2025

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 77 out of 102 jobs passed in 3 hours 24 minutes

Base Branch:

Upstream Comparison:

25 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Feb 5, 2025

albertojml commented Feb 6, 2025

albertojml commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025

✔️ ci:test:stable - 25 out of 25 jobs passed

❌ ci:test:relevant - 78 out of 99 jobs passed in 3 hours 10 minutes

Base Branch:

Upstream Comparison:

21 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Feb 6, 2025

albertojml commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025

liferay-continuous-integration commented Feb 6, 2025