Remove upper limit on pinned django version, only keep Django>=3.2 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@brianjbuck Let me know if you think we should add a test with various django versions? Or atleast include the "latest" one on pypi. This might help get ahead of the problem of broken compatibility in the future, in case some interface changes. |
sidmitra
changed the title
|
Hey @brianjbuck , this seems like a very safe change to merge in, and will let people use your awesome library in Django 4.x without having without having to override the version resolver in tools like |
|
when will it be merged? |
|
+1 @brianjbuck 🙏
|
carlkibler
approved these changes
Oct 21, 2022
|
@brianjbuck Can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a periodic pull request for each minor Django version, perhaps only pinning the lower limit is a better tradeoff.
Related PRs