Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacks taken from @amock to make RISC-V build. #1436

Closed
wants to merge 1 commit into from

Conversation

xfbs
Copy link
Contributor

@xfbs xfbs commented Dec 11, 2021

As stated in #1419, trying to get RISC-V to build. This uses generic C code for montomery multiplication taken from @amock. But it builds and tests successfully like this.

@briansmith
Copy link
Owner

Thanks for the PR! Could you rebase this on top of #1558? I think we just need the base.h changes now.

@briansmith
Copy link
Owner

Also, could you add the changes to the scripts in mk/ to get cargo.sh test working for some RISC-V targets in QEMU? This will enable us to more easily work on adding RISC-V-specific code paths in the future.

light4 added a commit to light4/ring that referenced this pull request Jan 10, 2023
@light4 light4 mentioned this pull request Jan 10, 2023
light4 added a commit to light4/ring that referenced this pull request Jan 10, 2023
sameo pushed a commit to sameo/ring that referenced this pull request Feb 24, 2023
@olof-nord
Copy link

This PR allows me to build ring locally, thanks!
But with this branch several years old, it is 442 commits behind :)

It would be fantastic to get this working on riscv - for example to run lemmy on riscv hardware.

I understand the generic approach suggested there, I will keep my eyes open for updates!
#1455

@briansmith
Copy link
Owner

Thanks. For now I'm planning to go with the simpler PR #1627. If you want, we can revisit the extended changes you have here, afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants