Fix comparisons with unions in runtime/sam/expr (#5210)

Fix by calling zed.Value.Under in expr.Compare.Eval.
brimdata · Aug 9, 2024 · ca81f72 · ca81f72
1 parent 54a5a15
commit ca81f72
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/runtime/sam/expr/eval.go b/runtime/sam/expr/eval.go
@@ -292,6 +292,8 @@ func (c *Compare) Eval(ectx Context, this zed.Value) zed.Value {
 	if rhs.IsError() {
 		return rhs
 	}
+	arena := ectx.Arena()
+	lhs, rhs = lhs.Under(arena), rhs.Under(arena)
 
 	if lhs.IsNull() {
 		if rhs.IsNull() {

diff --git a/runtime/sam/expr/expr_test.go b/runtime/sam/expr/expr_test.go
@@ -208,6 +208,15 @@ func TestCompareNumbers(t *testing.T) {
 	testSuccessful(t, "u <= f", rec2, "false")
 	testSuccessful(t, "u > f", rec2, "true")
 	testSuccessful(t, "u >= f", rec2, "true")
+
+	// Test comparisons with unions.
+	const rec3 = "{l:1((int64,bytes)),r:2.((string,float64))}"
+	testSuccessful(t, "l == r", rec3, "false")
+	testSuccessful(t, "l != r", rec3, "true")
+	testSuccessful(t, "l < r", rec3, "true")
+	testSuccessful(t, "l <= r", rec3, "true")
+	testSuccessful(t, "l > r", rec3, "false")
+	testSuccessful(t, "l >= r", rec3, "false")
 }
 
 func TestCompareNonNumbers(t *testing.T) {