Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparisons with unions in runtime/sam/expr #5210

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

nwt
Copy link
Member

@nwt nwt commented Aug 9, 2024

Fix by calling zed.Value.Under in expr.Compare.Eval.

Closes #5209.

Fix by calling zed.Value.Under in expr.Compare.Eval.
@nwt nwt requested a review from a team August 9, 2024 04:46
@nwt nwt merged commit ca81f72 into main Aug 9, 2024
3 checks passed
@nwt nwt deleted the fix-comparisons-with-unions branch August 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect comparison result with union value
2 participants