WX-1810 WX-1830 n1/n2/n2d machine types, cpuPlatform on GCPBATCH #7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
force-pushed
the
wx_1830_cpu_platform_batch
branch
from
1372cff
to
b24f569
Compare
mcovarr
changed the title
aednichols
approved these changes
Aug 28, 2024
AlexITC
approved these changes
Aug 28, 2024
| googleLegacyMachineSelection = false, | ||
| jobLogger = jobLogger | ||
| ) | ||
| val instancePolicy = createInstancePolicy(cpuPlatform, spotModel, accelerators, allDisks, machineType) |
There was a problem hiding this comment.
Consider using named arguments to avoid confusing cpuPlatform/machineType because both are strings.
| // Similarly, CPU platform of AMD Rome corresponds to the machine type n2d. | ||
| val customMachineType = | ||
| cpuPlatformOption match { | ||
| case Some(GcpBatchRuntimeAttributes.CpuPlatformIntelCascadeLakeValue) => N2CustomMachineType | ||
| case Some(GcpBatchRuntimeAttributes.CpuPlatformIntelIceLakeValue) => N2CustomMachineType |
There was a problem hiding this comment.
We can cover this with tests at GcpBatchMachineConstraintsSpec
|
Addreses #7474 |
javiergaitan
pushed a commit
to deepgenomics/cromwell
that referenced
this pull request
Oct 4, 2024
ovesh
pushed a commit
to deepgenomics/cromwell
that referenced
this pull request
Oct 10, 2024
…e backend (#1) * WX-1810 WX-1830 n1/n2/n2d machine types, cpuPlatform on GCPBATCH (broadinstitute#7518) * feat: [GCP Batch] Support passing standard machine types to the Google backend --------- Co-authored-by: Miguel Covarrubias <mcovarr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
GcpBatchMachineConstraints#machineTypeto choose the appropriate machine type for GCP Batch.Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes