-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 3 #28
Conversation
@@ -388,7 +388,7 @@ object PoolQConfig { | |||
// run control | |||
args += (("row-matcher", config.rowMatchFn)) | |||
args += (("col-matcher", config.colMatchFn)) | |||
if (config.countAmbiguous) { | |||
if config.countAmbiguous then { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Braces with then
?
Personally, if I were going to switch to OTOH, I have no interest in being a style nazi either. 🐱 🌔 🎱 |
I just run the compiler through with the first set of options described here: Namely, Because Scala 3's syntactic changes are so new, I decided not to go to the indentation significant route yet. I may well go the route of significant indentation here at some point, though. If people feel like PoolQ should go whole hog, I'm happy to run the next set of compiler syntax rewrites. Perhaps I'll do that anyway and provide it as a commit at the end here, which we could decide to keep or drop. |
6dc9eae
to
4eccf03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rolled back the indentation-significant syntax changes. There is a bug in scalafmt that I can't work around. See my comment on
That issue is closed, I'm going to either open a new one or get them to re-open that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
fyi: https://scalameta.org/scalafmt/docs/configuration.html#rewritescala3converttonewsyntax |
Explicitly set `removeUnused` to `false`
Closing in favor of #34 |
#5