Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Scala 3 (with newly released scalafmt) #34

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Port to Scala 3 (with newly released scalafmt) #34

merged 10 commits into from
Feb 22, 2024

Conversation

mtomko
Copy link
Collaborator

@mtomko mtomko commented Feb 20, 2024 •
edited
Loading

Ports code to Scala 3, making use of updates in scalafmt to convert to new syntax. Resolves #5 and supercedes #28.

@mtomko mtomko self-assigned this Feb 20, 2024
@mtomko mtomko mentioned this pull request Feb 20, 2024
Closed
mtomko
mtomko commented Feb 20, 2024
View reviewed changes
Copy link
Collaborator Author

@mtomko mtomko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci build is blocked on scalameta/scalafmt#3787

tmgreen
tmgreen approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@tmgreen tmgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mtomko
mtomko commented Feb 22, 2024
View reviewed changes
Copy link
Collaborator Author

@mtomko mtomko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked around the scalafmt issue. I'm going to go ahead and merge this!

@mtomko mtomko merged commit f119692 into main Feb 22, 2024
1 check passed
@mtomko mtomko deleted the scala3-take2 branch February 22, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmgreen tmgreen tmgreen approved these changes

Assignees

@mtomko mtomko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to Scala 3
2 participants
@mtomko @tmgreen