add support for serving via ssl #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
requested changes
Nov 23, 2017
| @@ -15,6 +15,7 @@ function broccoliCLI () { | |||
| .description('start a broccoli server') | |||
| .option('--port <port>', 'the port to bind to [4200]', 4200) | |||
| .option('--host <host>', 'the host to bind to [localhost]', 'localhost') | |||
| .option('--ssl', 'serve via https') | |||
There was a problem hiding this comment.
Lets do:
--ssl (Boolean) (Default: false)
--ssl-key (String) (Default: ssl/server.key)
--ssl-cert (String) (Default: ssl/server.crt)
| var sslOptions | ||
| try { | ||
| sslOptions = { | ||
| key: fs.readFileSync(path.join(process.cwd(), 'ssl/server.key')), |
There was a problem hiding this comment.
path.join(process.cwd() here is not needed, cwd is implied when using fs.* methods
| cert: fs.readFileSync(path.join(process.cwd(), 'ssl/server.crt')) | ||
| } | ||
| } catch(e) { | ||
| throw new Error('SSL key and certificate files must be located at ssl/server.key and ssl/server.crt') |
There was a problem hiding this comment.
this error message likely should include cwd in the errors.
|
@JakeDetels sorry for the late review, if you can make the above changes. We can merge and |
|
@stefanpenner: I'll update this by end-of-month.. |
|
Friendly ping 😺 |
|
landed via #417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to run server using SSL via
broccoli serve -ssl.SSL key and certificate files must be located in the user's project root at
ssl/server.keyandssl/server.crt.