Support serving over HTTPS #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sivasubramanyam A <ssdragonar5@gmail.com> Co-authored-by: jakedetels <jake.detels@gmail.com>
astronomersiva
commented
Jul 13, 2019
| ) { | ||
| const server = new Server(watcher, host, port, _connect, ui); | ||
| const server = new Server(watcher, host, port, _connect, ui, ssl, sslKey, sslCert); |
There was a problem hiding this comment.
This kind of looks error prone. We should consider changing this signature to accept an object instead of individual parameters like these.
There was a problem hiding this comment.
Sounds good, although I suspect we don't need to block this PR on it.
|
a gentle reminder @stefanpenner |
stefanpenner
approved these changes
Jul 26, 2019
| ) { | ||
| const server = new Server(watcher, host, port, _connect, ui); | ||
| const server = new Server(watcher, host, port, _connect, ui, ssl, sslKey, sslCert); |
There was a problem hiding this comment.
Sounds good, although I suspect we don't need to block this PR on it.
|
@astronomersiva thanks for the reminder, sorry about the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically an iteration of #296. Rebasing it turned out to be too hard so I handed up doing it from scratch.