Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow, recommendations and search): Add recommendations, flow and playlist search functions #689

Merged

Conversation

arctixdev
Copy link
Contributor

@arctixdev arctixdev commented Apr 10, 2023

This PR adds:

  • Function for getting users flow (Only the generic flow)

  • Getting recommended tracks, playlists, albums and artists

  • Searching for playlists

  • Include tests for bug fix and new functionality

  • Updated documentation for new feature

@arctixdev arctixdev marked this pull request as draft April 10, 2023 18:30
@arctixdev
Copy link
Contributor Author

Should i just remove the tests for the features that need a valid access_token?

@arctixdev arctixdev force-pushed the feature/more_playlist_features branch from 5cac891 to fcd24c5 Compare April 10, 2023 18:45
@arctixdev arctixdev changed the title Add recommendations, flow and playlist search feat(flow, recommendations and search) Add recommendations, flow and playlist search functions Apr 10, 2023
@arctixdev arctixdev changed the title feat(flow, recommendations and search) Add recommendations, flow and playlist search functions feat(flow, recommendations and search): Add recommendations, flow and playlist search functions Apr 10, 2023
@browniebroke
Copy link
Owner

Should i just remove the tests for the features that need a valid access_token?

You should obtain an API token as described in the contributing guide, and run the tests with it.

It should record the request/responses in cassettes (with token hidden), which can be used by others and on CI to run tests without actually executing the requests.

tests/test_client.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #689 (494773f) into main (0cd1708) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 494773f differs from pull request most recent head 8c49587. Consider uploading reports for the commit 8c49587 to get more accurate results

@@            Coverage Diff            @@
##              main      #689   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          637       649   +12     
  Branches        49        49           
=========================================
+ Hits           637       649   +12     
Impacted Files Coverage Δ
src/deezer/client.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arctixdev arctixdev force-pushed the feature/more_playlist_features branch from efd91d1 to 554f6c6 Compare April 12, 2023 12:06
@arctixdev arctixdev marked this pull request as ready for review April 12, 2023 12:08
@arctixdev arctixdev temporarily deployed to release April 12, 2023 12:13 — with GitHub Actions Inactive
src/deezer/client.py Outdated Show resolved Hide resolved
@arctixdev arctixdev temporarily deployed to release April 12, 2023 13:38 — with GitHub Actions Inactive
@browniebroke browniebroke force-pushed the feature/more_playlist_features branch from 494773f to 8c49587 Compare April 13, 2023 09:07
@browniebroke browniebroke temporarily deployed to release April 13, 2023 09:13 — with GitHub Actions Inactive
@browniebroke browniebroke merged commit 70a9a19 into browniebroke:main Apr 13, 2023
@browniebroke
Copy link
Owner

@all-contributors please add @Un10ck3d for code, docs, test

@allcontributors
Copy link
Contributor

@browniebroke

I've put up a pull request to add @Un10ck3d! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants