-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flow, recommendations and search): Add recommendations, flow and playlist search functions #689
feat(flow, recommendations and search): Add recommendations, flow and playlist search functions #689
Conversation
Should i just remove the tests for the features that need a valid access_token? |
5cac891
to
fcd24c5
Compare
You should obtain an API token as described in the contributing guide, and run the tests with it. It should record the request/responses in cassettes (with token hidden), which can be used by others and on CI to run tests without actually executing the requests. |
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 637 649 +12
Branches 49 49
=========================================
+ Hits 637 649 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
efd91d1
to
554f6c6
Compare
494773f
to
8c49587
Compare
@all-contributors please add @Un10ck3d for code, docs, test |
I've put up a pull request to add @Un10ck3d! 🎉 |
This PR adds:
Function for getting users flow (Only the generic flow)
Getting recommended tracks, playlists, albums and artists
Searching for playlists
Include tests for bug fix and new functionality
Updated documentation for new feature