-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deezer music provider #625
Merged
marcelveldt
merged 96 commits into
music-assistant:main
from
arctixdev:initial_deezer_support
May 8, 2023
Merged
Deezer music provider #625
marcelveldt
merged 96 commits into
music-assistant:main
from
arctixdev:initial_deezer_support
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
reviewed
Apr 21, 2023
marcelveldt
reviewed
Apr 21, 2023
…p is missing in the helper, due to that I had to comment it out
… to figure out which format we should request for a user based on his/her license
…se. Implement the seek feature.
…maserver into initial_deezer_support
…aserver into initial_deezer_support
…alls. Only add available tracks to the database. For unavailble Tracks we sometimes get data errors, when trying to get the album or artist information so that we should not add them to our db at all.
marcelveldt
reviewed
May 8, 2023
marcelveldt
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Deezer as a Music Provider
https://github.com/orgs/music-assistant/discussions/434