Add getzmqnotifications RPC in rpcclient #1555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyb
suggested changes
May 23, 2020
btcjson/chainsvrcmds.go
Outdated
| @@ -864,6 +873,7 @@ func init() { | |||
| MustRegisterCmd("gettxout", (*GetTxOutCmd)(nil), flags) | |||
| MustRegisterCmd("gettxoutproof", (*GetTxOutProofCmd)(nil), flags) | |||
| MustRegisterCmd("gettxoutsetinfo", (*GetTxOutSetInfoCmd)(nil), flags) | |||
| MustRegisterCmd("getzmqnotifications", (*GetZmqNotificationsCmd)(nil), flags) | |||
There was a problem hiding this comment.
Wondering if getzmqnotifications is really a chain command. Bitcoin Core categorizes it separately under the zmq section. Maybe walletsvrcmds.go is a better file for this?
What do you think, @jcvernaleo @jakesyl?
btcjson/chainsvrresults.go
Outdated
Comment on lines
402
to
406
| type basicNotification struct { | ||
| Type string | ||
| Address string | ||
| Hwm int | ||
| } |
There was a problem hiding this comment.
We can use this in the MarshalJSON method as well, as a replacement for map[string]interface{} type, by moving basicNotification outside.
What do you think?
There was a problem hiding this comment.
A benefit of keeping basicNotification within the unmarshaling method is that it doesn't pollute the package namespace. So I think it's better to keep it where it is now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we implement the getzmqnotifications RPC
in the RPC client.