rpcclient: add getzmqnotifications RPC #1587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@torkelrogstad This needs a rebase, and fixing of failing unit-tests. |
torkelrogstad
force-pushed
the
master
branch
3 times, most recently
from
6082bd9 to
18e9886
Compare
|
@onyb Rebased |
onyb
suggested changes
Jun 30, 2020
btcjson/chainsvrresults.go
Outdated
| @@ -398,6 +399,63 @@ type GetRawMempoolVerboseResult struct { | |||
| Depends []string `json:"depends"` | |||
| } | |||
|
|
|||
| // GetZmqNotificationResult models the data returned from the getzmqnotifications command. | |||
| type GetZmqNotificationResult []struct { | |||
| Type string // Type of notification | |||
There was a problem hiding this comment.
We can use an enumeration for the Type. According to the Bitcoin Core docs, the possible notification types are very limited.
pubhashtxpubhashblockpubrawblockpubrawtx
What do you think?
btcjson/chainsvrcmds.go
Outdated
| @@ -668,6 +668,15 @@ func NewInvalidateBlockCmd(blockHash string) *InvalidateBlockCmd { | |||
| } | |||
| } | |||
|
|
|||
| // GetZmqNotificationsCmd defines the getzmqnotifications JSON-RPC command. | |||
There was a problem hiding this comment.
Refer to my comment on your other PR:
Should we put zmq stuff in separate files (ex: zmq*.go), or go with chain*.go files?
There was a problem hiding this comment.
Moved to ZMQ prefixed files. Kept the test cases where they are though, to avoid repeating all the boilerplate
|
Looks like this needs a rebase to get the correct github actions and to deal with some conflicts. |
torkelrogstad
force-pushed
the
master
branch
from
18e9886 to
4dc4ff7
Compare
|
Git remotes are hard... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is #1555 take 2. I force-pushed to the wrong branch when responding to review, which closed the PR automatically. GitHub then complained that there were no new commits on my branch, so I could not reopen the PR. I'm therefore opening this instead.
@onyb note that I responded to your review comments.