feat: support for background mode iOS 13+ #28
Conversation
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
cbcce95 to
b79fe04
Compare
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
b79fe04 to
ee7f6f8
Compare
duyhungtnn
changed the title
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
72fd7c4 to
b30c23d
Compare
|
Tested on a real device to verify it works 
|
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
186382e to
f2d7b70
Compare
| } | ||
|
|
||
| @objc func onForeground() { | ||
| // noted: from iOS 16, the app will receive both UIApplication.didFinishLaunchingNotification | ||
| // & UIScene.willConnectNotification when the app launching | ||
| guard isOnForeground == false else { return } |
There was a problem hiding this comment.
The isOnForeground is not thread-safe.
Also, I think we should always reschedule the foreground tasks when they change instead of ignoring them when they are already in the foreground for this case.
How about registering the notifications according to the OS version?
So we can avoid calling twice from iOS 16.
Also, I didn't find the notification willConnectNotification described in the comment.
Let me know your thoughts.
There was a problem hiding this comment.
I updated this logic a little, it seems we were using incorrect notifications for listening.
Currently no more duplicate events for on_foreground after app launched
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
6 times, most recently
from
4602db2 to
71ab47b
Compare
| BKTBackgroundTask.enable() | ||
| return self | ||
| } | ||
| } |
There was a problem hiding this comment.
Supporting SwiftUI from iOS 14
| ContentView() | ||
| } | ||
| .enableBKTBackgroundTask() | ||
| } |
There was a problem hiding this comment.
Here is how to register background task for SwiftUI app
| @@ -83,7 +89,7 @@ final class TaskScheduler { | |||
| onForeground() | |||
| } | |||
|
|
|||
| @objc private func onUISceneWillEnterForeground() { | |||
| @objc private func onUISceneDidActive() { | |||
| component.config.logger?.debug(message: "[TaskScheduler]: onUISceneWillEnterForeground") | |||
There was a problem hiding this comment.
nit: onUISceneWillEnterForeground -> onUISceneDidActive
|
@duyhungtnn, please fix the conflict rebasing from the main branch. |
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
f01dabc to
aa04ad5
Compare
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
aa04ad5 to
9a3934d
Compare
|
@cre8ivejp I fixed the conflict and rebase the code |
duyhungtnn
force-pushed
the
fix/background-task-did-not-work
branch
from
b9d5422 to
68b365c
Compare
cre8ivejp
changed the title
Changes