Fix path to dlls on windows
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
djc
reviewed
Feb 1, 2022
| struct Person<'a>(&'a str); | ||
| fn main() { | ||
| let _ = Person("#bors"); | ||
| let _ = Person::from("#bors"); |
There was a problem hiding this comment.
Is this necessary to test the behavior on Windows?
There was a problem hiding this comment.
This line isn't necessary. It's even enough to make sure that any external proc macro is visible, so in case of this PR, use derive_more::From;
The main idea is that proc macros are always compiled as dynamic libraries, so if we are able to use them, we are sure, that they are linked.
There was a problem hiding this comment.
Okay, if we need the extra dependency I'm fine leaving it like this.
Can you fix up the formatting? I'll merge after that.
|
I've published 0.13.7 so you should be able to pick this up in your crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131
It looks like for some reason
dlls aren't prefixed withlibon windows.