Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix book examples #202

Merged
merged 14 commits into from
Feb 2, 2022
Merged

Fix book examples #202

merged 14 commits into from
Feb 2, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Jan 31, 2022 •
edited by tyranron
Loading

Synopsis

Windows doesn't handle path starting with /.

Solution

Remove / prefix and add Windows and macOS targets for test-book CI job.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Jan 31, 2022
@ilslv ilslv self-assigned this Jan 31, 2022
@ilslv
Copy link
Member Author

ilslv commented Jan 31, 2022

@tyranron for some reason skeptic tests are failing on windows, while macOS works fine 🤷‍♂️. So lets release 0.11.3 with #201 this PR later with 0.11.4

@ilslv
Copy link
Member Author

ilslv commented Feb 1, 2022

Issue is definitely on skeptic side of things: budziq/rust-skeptic#131

@tyranron
Copy link
Member

tyranron commented Feb 1, 2022

@ilslv seems that we should made a fix there 🙃

@ilslv
Copy link
Member Author

ilslv commented Feb 1, 2022

@tyranron yeah, already working on it. Looks like something wrong with parsing on windows, because ubuntu and macOS rustc commands contain link to the crates.io dependency: "async_trait=/home/runner/work/skeptic-mre/skeptic-mre/book/tests/target/debug/deps/libasync_trait-9a7703a13941d9d0.so", while windows lacks it.

@ilslv
Copy link
Member Author

ilslv commented Feb 1, 2022

Waiting for merge of budziq/rust-skeptic#132

@ilslv ilslv added the blocked Blocked for moving on by some condition label Feb 1, 2022
@ilslv ilslv removed the blocked Blocked for moving on by some condition label Feb 2, 2022
@ilslv ilslv added this to the 0.11.4 milestone Feb 2, 2022
@ilslv ilslv requested a review from tyranron February 2, 2022 04:57
@ilslv
Copy link
Member Author

ilslv commented Feb 2, 2022 •
edited by tyranron
Loading

FCM

Fix Book examples on Windows (#202, #200)

tyranron
tyranron approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv perfect! thanks! 🍻

@tyranron tyranron added the k::documentation Related to project documentation label Feb 2, 2022
@tyranron tyranron merged commit 644abfc into main Feb 2, 2022
@tyranron tyranron deleted the fix-book-examples branch February 2, 2022 10:26
@tyranron tyranron mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron