Enable default features in prost dependencies #1344
Conversation
Since we're not supporting `no_std` crates, we should enable the `std` feature by default.
|
Related public slack post. Ultimately, not all crates need the |
| @@ -16,6 +16,7 @@ registry: | |||
| - name: "prost" | |||
| req: "0.12.3" | |||
| default_features: false | |||
| features: ["std"] | |||
There was a problem hiding this comment.
Is this difference between this and setting default_features: true that it would enable the derive feature too?
There was a problem hiding this comment.
yeah, that's the difference. Not sure if we want to enable derive or not. My vague understanding (from the README) is that it's more for user-generated types, but OTOH the custom derive macro is added to the generated code.
Let's maybe just add it (by using default_features: true) — it's a single extra crate with no dependencies.
| @@ -16,6 +16,7 @@ registry: | |||
| - name: "prost" | |||
| req: "0.12.3" | |||
| default_features: false | |||
| features: ["std"] | |||
| # prost-types is necessary for any module using the WKTs. | |||
| - name: "prost-types" | |||
There was a problem hiding this comment.
Should we do the same here? https://docs.rs/prost-types/0.13.1/prost_types/#feature-flags
stefanvanburen
changed the title
std feature to prost dependency
Since we're not supporting
no_stdcrates, we should enable thestdfeature by default. (This happens to be the same asdefault_featurescurrently, but that may change in the future.)