Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default features in prost dependencies #1344

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Enable default features in prost dependencies #1344

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
990ad1e
Add `std` feature to prost dependency
stefanvanburen Jul 12, 2024
a551a20
Merge branch 'main' into svanburen/add-prost-std-feature
stefanvanburen Jul 12, 2024
b1794e7
Enable default features
stefanvanburen Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/community/neoeinstein-prost/v0.3.1/buf.plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ registry:
- name: "prost"
req: "0.12.3"
default_features: false
features: ["std"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this difference between this and setting default_features: true that it would enable the derive feature too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's the difference. Not sure if we want to enable derive or not. My vague understanding (from the README) is that it's more for user-generated types, but OTOH the custom derive macro is added to the generated code.

Let's maybe just add it (by using default_features: true) — it's a single extra crate with no dependencies.

# prost-types is necessary for any module using the WKTs.
- name: "prost-types"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same here? https://docs.rs/prost-types/0.13.1/prost_types/#feature-flags

req: "0.12.3"
Expand Down