Make tsNocheck works correctly #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timostamm
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thank you for the fix, @yukukotani!
This needs some updates to tests. You can run make to see where, but you need bazel and other tools installed.
Let's get this merged and I'll follow up with an update to the tests.
|
@timostamm Oops, Sorry I didn't notice CONTRIBUTING.md exists! I'll do that myself next time. Thank you. |
timostamm
added a commit
that referenced
this pull request
Nov 2, 2022
smaye81
pushed a commit
that referenced
this pull request
Nov 11, 2022
smaye81
pushed a commit
that referenced
this pull request
Nov 11, 2022
Merged
smaye81
added a commit
that referenced
this pull request
Nov 23, 2022
This release includes the following: ## Enhancements * Add a toJSON method to messages by @smaye81 in #306 * Add an unpack function to `google.protobuf.Any` by @smaye81 in #303 * Make generated imports look more normal by @dimitropoulos in #298⚠️ Note that as a result of this PR, import statements in your generated code will contain diffs when generated with `v0.3.0` as the import statements will have spaces added. For example: ```diff - import {FooMessage} from './foo_message_pb.js'; + import { FooMessage } from './foo_message_pb.js'; ``` * Add print function with tagged template literal by @yukukotani in #279 * Enhance the `Any.is` function by @smaye81 in #294 * Make wrappers more lenient by @timostamm in #291 ## Bugfixes * Fix map equality by @calebdoxsey in #305 * Make `tsNocheck` work correctly by @yukukotani in #275 ## New Contributors @calebdoxsey made their first contribution in #305 @yukukotani made their first contributions in #275 and #279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/* @ts-nocheck */won't disable type check.// @ts-nocheckis the correct syntax.