makes generated imports look more normal #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by searching for:
```
import( type)? \{(\S)(.*)(\S)\}
```
and replacing with
```
import$1 { $2$3$4 }
```
dimitropoulos
force-pushed
the
dimitri/imports
branch
from
bc3849c to
2657ac7
Compare
timostamm
reviewed
Nov 10, 2022
timostamm
approved these changes
Nov 10, 2022
smaye81
pushed a commit
that referenced
this pull request
Nov 11, 2022
Merged
smaye81
added a commit
that referenced
this pull request
Nov 23, 2022
This release includes the following: ## Enhancements * Add a toJSON method to messages by @smaye81 in #306 * Add an unpack function to `google.protobuf.Any` by @smaye81 in #303 * Make generated imports look more normal by @dimitropoulos in #298⚠️ Note that as a result of this PR, import statements in your generated code will contain diffs when generated with `v0.3.0` as the import statements will have spaces added. For example: ```diff - import {FooMessage} from './foo_message_pb.js'; + import { FooMessage } from './foo_message_pb.js'; ``` * Add print function with tagged template literal by @yukukotani in #279 * Enhance the `Any.is` function by @smaye81 in #294 * Make wrappers more lenient by @timostamm in #291 ## Bugfixes * Fix map equality by @calebdoxsey in #305 * Make `tsNocheck` work correctly by @yukukotani in #275 ## New Contributors @calebdoxsey made their first contribution in #305 @yukukotani made their first contributions in #275 and #279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this change is that we should take the opportunity, when it arises, to make generated code look natural and typical (if possible). While this isn't a logical change, it's hopefully worthwhile in the pursuit of making the generated outputs feel more normal.
Here's an example:
Note that this falls in line with Prettier's default as well. In fact, that's how I found it. I was generating code and trying to aim for a final output that matched prettier's default formatting and this was the only thing that I wasn't able to make match as a downstream consumer of protobuf-es.