Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes generated imports look more normal #297

Closed

Conversation

dimitropoulos
Copy link
Contributor

The rationale for this change is that we should take the opportunity, when it arises, to make generated code look natural and typical (if possible). While this isn't a logical change, it's hopefully worthwhile in the pursuit of making the generated outputs feel more normal.

Here's an example:

- import {Message, proto3} from "@bufbuild/protobuf";
+ import { Message, proto3 } from "@bufbuild/protobuf";

Note that this falls in line with Prettier's default as well. In fact, that's how I found it. I was generating code and trying to aim for a final output that matched prettier's default formatting and this was the only thing that I wasn't able to make match as a downstream consumer of protobuf-es.

@dimitropoulos dimitropoulos changed the base branch from main to dimitri/imports November 10, 2022 20:29
@dimitropoulos
Copy link
Contributor Author

closing in favor of #298 so I can switch from the remote to here

@dimitropoulos dimitropoulos deleted the dimitri/imports branch November 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant