Upgrade to protobuf v22.0 #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Feb 22, 2023
timostamm
approved these changes
Feb 28, 2023
This was referenced Feb 28, 2023
Closed
Closed
Merged
smaye81
added a commit
that referenced
this pull request
Mar 2, 2023
This release includes the following: ## Enhancements * Support size-delimited messages by @timostamm in #387. ## Bug Fixes * Upgrade to Protobuf v22.0 by @smaye81 in #394. * Fix type declaration emitting when using NodeNext module resolution by @fubhy in #398. * Strip rewrite_imports parameter by @smaye81 in #386. ## New Contributors * @s-hakase made their first contribution in #367. * @balzdur made their first contribution in #368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Protobuf-ES to v22.0. A few changes were involved. Notably:
protocolbuffers/protobuf@ca1cb1b added checks to expect a failure when attempting to serialize
NaNorInfinitywith theValueWKT. This adds these checks to our generatedValuecode to adhere to the conformance spec.This PR added conformance checks to check for negative values in the
DurationWKT. This adds additional checks and unit tests to our generatedDurationcode to handle negative durations and adhere to the conformance spec.protoc was changed to check the
json_nameoption, and give errors for case-sensitive conflict, which caused some of our tests to fail. Tests have been updated.Note that v22.0 also mentions the new
editionssyntax, although this is not used anywhere. Protobuf-ES validates thesyntaxvalue is only eitherproto2orproto3so we are handling this effectively at this point. An example error message ifeditionsis used: