Fix type declaration emitting when using NodeNext module resolution #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubhy
changed the title
fubhy
changed the title
fubhy
commented
Feb 23, 2023
timostamm
reviewed
Feb 24, 2023
There was a problem hiding this comment.
Can confirm that d99b803 fails the tests 👍
Seems that declarationMap is not necessary to trigger, but I think it's a good call to leave it in.
Can you make the simplification with typeof protoN and re-using the dist directory and add explanatory comments suggested below?
|
@timostamm Thanks for the review. I force-pushed two commits on top of the test-failure demonstration commit to make it easier to re-review for you (considering all the noise with the generated files). |
timostamm
approved these changes
Feb 24, 2023
| @@ -10,5 +10,5 @@ server would usually do. | |||
|
|
|||
| | code generator | bundle size | minified | compressed | | |||
| |---------------------|------------------------:|-----------------------:|-------------------:| | |||
| | protobuf-es | 86,785 b | 36,950 b | 9,642 b | | |||
| | protobuf-es | 86,785 b | 36,950 b | 9,654 b | | |||
There was a problem hiding this comment.
Just for posterity: This is the usual flake we get from using Node.js zlib on different platforms. I don't see any bundle size change.
This was referenced Feb 28, 2023
Closed
Closed
Merged
smaye81
added a commit
that referenced
this pull request
Mar 2, 2023
This release includes the following: ## Enhancements * Support size-delimited messages by @timostamm in #387. ## Bug Fixes * Upgrade to Protobuf v22.0 by @smaye81 in #394. * Fix type declaration emitting when using NodeNext module resolution by @fubhy in #398. * Strip rewrite_imports parameter by @smaye81 in #386. ## New Contributors * @s-hakase made their first contribution in #367. * @balzdur made their first contribution in #368.
1 task
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
--noEmitwhen testing compilation with the various tsc versions and configuresdeclarationsanddeclarationMapto be emitted.Adds a ProtoRuntime typehint to the
runtimeproperty on generated messages.Fixes #396