fix: propagate filter_stats to TUI metrics in native tool path#480
Merged
fix: propagate filter_stats to TUI metrics in native tool path#480
Conversation
handle_native_tool_calls was discarding ToolOutput.filter_stats, causing filter_applications to remain zero and the TUI filter block to stay hidden. Replicate the same update_metrics and inline stats logic from handle_tool_result. Also remove the spurious ToolEvent::Completed emitted in shell.rs before filtering is applied (filter_stats: None). The second event after filtering already carries correct per_block_stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_native_tool_callswas silently discardingToolOutput.filter_stats, keepingfilter_applicationsat 0 and the TUI filter block permanently hiddenToolEvent::Completedemission in shell executor that sentfilter_stats: Nonebefore filtering was appliedChanges
zeph-core/agent/streaming.rs— replicatehandle_tool_resultfilter metrics logic inhandle_native_tool_calls: updateMetricsSnapshotcounters (raw/saved tokens, applications, commands, confidence distribution) and send inline stats to channelzeph-tools/shell.rs— remove earlyToolEvent::Completedwithfilter_stats: Noneemitted before filtering; keep only the post-filter event with correct statsTest plan
cargo nextest run --workspace --lib --bins— 1568 passed, 0 failedcargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— cleancargo run -- --tui, execute shell commands via native tool_use provider, verify filter stats appear in Resources panelCloses #448