fix: handle compound shell commands in output filter matchers#481
Merged
fix: handle compound shell commands in output filter matchers#481
Conversation
CommandMatcher now extracts the last command segment from compound expressions (cd /path && cargo test 2>&1 | tail) before matching. This fixes filters not triggering when LLMs prepend cd or append pipes/redirections to commands.
c6a6efb to
3eb3719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd /path && cargo test 2>&1 | tail -80CommandMatcher::matchesnow extracts the last command segment from&&/;chains, stripping trailing pipes and redirections before matchingcd, notcargoChanges
zeph-tools/filter/mod.rs— splitmatchesintomatches_single+ compound fallback viaextract_last_command; 4 new testsTest plan
cargo nextest run -p zeph-tools --lib— 344 passed, 0 failedcargo clippy --workspace -- -D warnings— clean--tui, verify filter stats appear in Resources panel for LLM-generated compound commands