refactor(http): consolidate HTTP client creation with default_client()#674
Merged
refactor(http): consolidate HTTP client creation with default_client()#674
Conversation
github-actions
bot
added
documentation
bug-ops
force-pushed
the
feat/http-client-consolidation
branch
from
400cb36 to
42c4a91
Compare
This was
linked to
issues
Feb 20, 2026
#627) Add default_client() helper in zeph-core and zeph-llm with standard timeouts (30s connect, 60s request), user-agent, and redirect policy. Replace 5 production Client::new() sites across claude, openai, slack, discord, and main bootstrap. Parallel module in zeph-llm due to circular dependency with zeph-core. Closes #666, #667
bug-ops
force-pushed
the
feat/http-client-consolidation
branch
from
42c4a91 to
71d1821
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_client()helper inzeph-core::httpandzeph-llm::httpwith standard timeouts (30s connect, 60s request), user-agentzeph/{version}, and redirect limit 10Client::new()calls: claude.rs, openai.rs, slack/api.rs, discord/rest.rs, main.rs12 files changed, +61 -5 lines.
Closes #627, #666, #667
Test plan
cargo +nightly fmt --check— passcargo clippy --workspace -- -D warnings— 0 warningscargo nextest run --workspace --lib --bins— 2035 passed, 9 skipped